# Tasks — add @suaveplan/notification-channel

> Every checkbox MUST reflect work actually done in this change. No retroactive ticking.

## 1. Spec authoring

- [x] 1.1 Read `../suaveplan/enterprise/notification-channel.md` end-to-end
- [x] 1.2 Read upstream `../suaveplan/packages/universal/notification-channel/src/` end-to-end
- [x] 1.3 Read `openspec/AGENTS.md` §§ 0a, 2a, 6a, 7, 12a, 13, 14
- [x] 1.4 Draft `proposal.md`
- [x] 1.5 Fill in `## Source mapping`
- [x] 1.6 Draft `specs/notification-channel/spec.md`
- [x] 1.7 Every requirement carries a `**Verified by:**` line

## 2. Implementation

- [x] 2.1 `package.json`, `tsconfig.lib.json`, `vite.config.ts`, `vitest.config.ts`, `tests/setup/polyfills.ts`
- [x] 2.2 `src/error-codes.ts` — `defineCodes("NOTIFICATION_CHANNEL", [...])` + typed subclasses
- [x] 2.3 `src/types/notification.types.ts` — `Notification`, channels, status, transitions
- [x] 2.4 `src/schemas/schemas.ts` — Zod schemas at every public boundary
- [x] 2.5 `src/hooks/hooks.ts` — generic `Hooks<TMap>` pipeline (local — `@suaveplan/events` does not export `Hooks` on genesis)
- [x] 2.6 `src/channels/delivery-channel.ts` — `DeliveryChannel`/`DeliveryResult`
- [x] 2.7 `src/channels/email-channel.ts`
- [x] 2.8 `src/channels/sms-channel.ts`
- [x] 2.9 `src/channels/push-channel.ts` + `push-channel.types.ts` (injectable `FetchLike`)
- [x] 2.10 `src/channels/in-app-channel.ts`
- [x] 2.11 `src/channels/webhook-channel.ts` (injectable `FetchLike`)
- [x] 2.12 `src/digest/digest-channel.ts` (injectable `Clock`)
- [x] 2.13 `src/templates/template-engine.ts`
- [x] 2.14 `src/rate-limiter/channel-rate-limiter.ts` (injectable `Clock`)
- [x] 2.15 `src/retry/delivery-retry.ts` (injectable `Clock` + sleeper)
- [x] 2.16 `src/scheduler/notification-scheduler.ts` (injectable `Clock`)
- [x] 2.17 `src/preferences/preference-manager.ts` (injectable `Clock`)
- [x] 2.18 `src/router/notification-router.ts` (uses genesis `EventBus`, OTel, hooks)
- [x] 2.19 `src/otel/metrics.ts` — counters + histogram + `refreshNotificationMeters`
- [x] 2.20 `src/fakes/fake-fetch.ts` — `FetchLike` test double
- [x] 2.21 `src/index.ts` — explicit named re-exports; side-effect-imports `./error-codes.js`

## 3. Tests

- [x] 3.1 Unit tests co-located beside each module; cover every public method + every error code at least once
- [x] 3.2 OTel test using real in-memory `MeterProvider`
- [x] 3.3 Tests import only from `@suaveplan/testing/runner`
- [x] 3.4 Every `it(...)` carries `{ timeout: 5000 }` (30000 for async I/O)

## 4. Documentation

- [x] 4.1 Sibling `.md` for every implementation `.ts` (≥200 words, basic + advanced examples)
- [x] 4.2 `README.md` at package root linking every co-located `.md` under `## Modules`

## 5. Pre-archive verification (the 5-gate triple)

- [x] 5.1 `bun run check` — Biome 0 errors / 0 warnings
- [x] 5.2 `bunx turbo lint typecheck test --filter=@suaveplan/notification-channel` — green
- [x] 5.3 `bunx turbo test:coverage --filter=@suaveplan/notification-channel` — 100/100/100/100
- [x] 5.4 `bun scripts/openspec-conformance.ts @suaveplan/notification-channel` — exit 0
- [x] 5.5 `bunx turbo build --filter=@suaveplan/notification-channel` — green

## 6. Pre-archive 7-row checklist (AGENTS.md §13)

- [x] 6.1 Generics threaded; literal-typed `defineCodes` union preserved through public surface
- [x] 6.2 Zod schemas wired at every declared boundary
- [x] 6.3 Every error code in `NOTIFICATION_CHANNEL_CODES` thrown by ≥1 production path
- [x] 6.4 Strict-mode behaviors tested (rate-limit window expiry, dead-letter handler optional, quiet-hours wrap-around)
- [x] 6.5 OTel instruments emit + asserted with real in-memory `MeterProvider`
- [x] 6.6 Lifecycle behaviors tested (cancel after send rejected, scheduler `start`/`stop` idempotent)
- [x] 6.7 No retroactive ticks

## 7. Archive

- [x] 7.1 Fold `specs/notification-channel/spec.md` into `openspec/specs/notification-channel/spec.md`
- [x] 7.2 Move `openspec/changes/add-notification-channel/` → `openspec/archive/2026-05-19-add-notification-channel/`