4.7 KiB
4.7 KiB
Tasks — form-detection
Every checkbox MUST reflect work actually done in this change. Do not retroactively tick boxes for work that was already in main when this change opened. Do not tick a box for a test that doesn't exist or doesn't pin the requirement it claims to verify. Retroactive ticking is the failure mode this template guards against.
0. Pre-flight (non-negotiable)
- 0.1 Confirm clean working tree (
git statusreports nothing) and no in-flight worktrees with uncommitted work (git worktree listthengit statusin each) - 0.2 If any worktrees exist under
.claude/worktrees/, account for each one: still-active agent, work-pending-merge, or stale-and-prune. Stale worktrees MUST be removed (git worktree remove) before opening a new one — code that has been lost twice on main is the failure mode this guards against. - 0.3 Confirm the package set in
MANIFEST.mdmatchesfind packages -maxdepth 3 -name package.jsoncount. Drift here means a prior change archived without regenerating the manifest.
1. Spec authoring
- 1.1 Read
MIGRATION.mdSections 4.2, 8, and 9 for package requirements and sequencing - 1.2 Read
openspec/AGENTS.mdSections 13 and 14 - 1.3 Draft
proposal.mdfromopenspec/templates/proposal.md - 1.4 Draft
specs/form-detection/spec.mdfromopenspec/templates/spec-delta.md - 1.5 Every requirement in the spec delta carries a
**Verified by:**line naming concreteit(...)titles
2. Implementation
- 2.1 Scaffold package at
packages/plugin/form-detectionwithpackage.json,tsconfig.json,vitest.config.ts - 2.2 Implement
detectFormsinsrc/detect/detect.tswith DOM traversal and form-candidate collection - 2.3 Implement
classifyFieldinsrc/classify/classify.tswith heuristic rule engine - 2.4 Implement
extractLabelinsrc/label/label.tswith multi-source label resolution - 2.5 Implement
scoreConfidenceinsrc/score/score.tswith weighted signal aggregation - 2.6 Implement
FormObserverinsrc/observer/observer.tswith debouncedMutationObserverwrapper - 2.7 Implement
FormDetectionErrorhierarchy insrc/error/error.tswith error codes - 2.8 Add subpath exports in
package.jsonfor every feature module - 2.9 Ensure bundle size stays under 10KB for core tree-shaken entry point
- 2.10 Wire Zod schemas at every declared boundary if external input is accepted
3. Tests
- 3.1 Unit tests at
src/detect/detect.test.tscovering every scenario - 3.2 Unit tests at
src/classify/classify.test.tscovering every scenario - 3.3 Unit tests at
src/label/label.test.tscovering every scenario - 3.4 Unit tests at
src/score/score.test.tscovering every scenario - 3.5 Unit tests at
src/observer/observer.test.tscovering every scenario - 3.6 Unit tests at
src/error/error.test.tscovering every scenario - 3.7 Spec-conformance tests at
src/spec-conformance.test.tspinning structural invariants - 3.8 Property-based tests for confidence-score monotonicity under signal addition
- 3.9 Every
it(...)carries{ timeout: 5000 }(or 30000 for genuinely async)
4. Documentation
- 4.1 Sibling
.mdfor every implementation.ts(≥200 words, basic + advanced examples, full API reference) - 4.2 README links every co-located
.mdunder## Modules - 4.3 Update
CLAUDE.mdpackage listing
5. Pre-archive verification (the 5-gate triple)
- 5.1
bun run check— Biome 0 errors / 0 warnings / 0 info across the whole monorepo - 5.2
bunx turbo lint typecheck test --filter=@suaveplan/form-detection— green - 5.3
bunx turbo test:coverage --filter=@suaveplan/form-detection— 100/100/100/100 - 5.4
bun scripts/openspec-conformance.ts @suaveplan/form-detection— exit 0, noerrorfindings - 5.5
bunx turbo build --filter=@suaveplan/form-detection— green
6. Pre-archive 7-row checklist (AGENTS.md Section 13)
- 6.1 Generics threaded;
expectTypeOfassertions on every literal-type claim - 6.2 Zod schemas wired at every declared boundary
- 6.3 Every error code in
error-codes.tsthrown by at least one production path - 6.4 Strict-mode behaviors tested both on and off
- 6.5 OTel instruments emitted from production paths and asserted with a real in-memory
MeterProvider - 6.6 Lifecycle dedup tested where claimed (in-flight Promise, idempotent set/load)
- 6.7 No retroactive tick — every box above reflects work done in this change
7. Archive
- 7.1 Fold spec delta into
openspec/specs/form-detection/spec.md - 7.2 Move
openspec/changes/form-detection/→openspec/archive/2026-04-29-form-detection/ - 7.3 Refresh
MANIFEST.mdif package set or deps changed