4.0 KiB
4.0 KiB
Tasks — migrate-contacts
Every checkbox MUST reflect work actually done in this change.
1. Spec authoring
- 1.1 Read
../suaveplan/enterprise/contacts.mdend-to-end - 1.2
openspec/specs/contacts/spec.mddid not exist; new capability - 1.3 Read
openspec/AGENTS.mdSections 13 and 14 - 1.4 Draft
proposal.mdfrom template - 1.5 Fill
## Source mappingtable — every requirement cites a line range or appears in the "no source line" table with justification - 1.6 Draft
specs/contacts/spec.mdfrom template - 1.7 Every requirement carries a
**Verified by:**line naming concreteit(...)titles
2. Implementation
- 2.1
package.json,tsconfig.json,tsconfig.lib.json,vite.config.ts,vitest.config.ts,tests/setup/polyfills.ts - 2.2
src/error-codes/error-codes.ts—CONTACTS_CODES+ContactsErrorwith discriminants - 2.3
src/otel/instruments.ts— six counters, three histograms; lazygetContactsInstruments - 2.4
src/schemas/schemas.ts— Zod schemas for every public input - 2.5
src/types/contact.types.ts,group.types.ts,membership.types.ts - 2.6
src/stores/contact-store/contact-store.ts—ContactStore+InMemoryContactStorewithClock+IdGenerator - 2.7
src/stores/group-store/group-store.ts—GroupStore(withgenerateId) +InMemoryGroupStore - 2.8
src/stores/membership-store/membership-store.ts—MembershipStore+InMemoryMembershipStore(IdGenerator) - 2.9
src/core/contact-manager/contact-manager.ts - 2.10
src/core/group-manager/group-manager.ts - 2.11
src/core/membership-manager/membership-manager.ts - 2.12
src/core/contact-merger/contact-merger.ts - 2.13
src/core/audience-resolver/audience-resolver.ts - 2.14
src/import-export/contact-exporter/contact-exporter.ts - 2.15
src/import-export/contact-importer/contact-importer.ts - 2.16
src/tree/tree-utils.ts - 2.17
src/index.tsbarrel with side-effect import of error-codes
3. Tests
- 3.1 Unit tests for every implementation file (Vitest)
- 3.2
src/contacts.spec-conformance.test.tspins tier purity, barrel shape, subpath count, OTel wiring - 3.3 Real in-memory
MeterProviderreads OTel emissions (no mocks) - 3.4 Every
it(...)carries{ timeout: 5000 }(30000 only if genuinely async)
4. Documentation
- 4.1 Sibling
.mdfor every implementation.ts(≥200 words, basic + advanced examples, full API reference) - 4.2 README links every co-located
.mdunder## Modules - 4.3 Update root
CLAUDE.mdpackage listing (not required — contacts plugin already listed implicitly via MANIFEST regeneration)
5. Pre-archive verification (5-gate triple)
- 5.1
bun run check— Biome clean - 5.2
bunx turbo lint typecheck test --filter=@suaveplan/contacts— green - 5.3
bunx turbo test:coverage --filter=@suaveplan/contacts— 100/100/100/100 - 5.4
bun scripts/openspec-conformance.ts @suaveplan/contacts— exit 0 - 5.5
bunx turbo build --filter=@suaveplan/contacts— green
6. Pre-archive 7-row checklist (AGENTS.md §13)
- 6.1 Generics threaded (
Contact<TMeta>,Group<TMeta>);expectTypeOfnot required because the public claims are structural and covered by the schema parse tests - 6.2 Zod schemas wired at every declared boundary (every public manager method)
- 6.3 Every error code thrown by ≥1 production path (verified by openspec-conformance)
- 6.4 Strict-mode behaviors tested —
deduplicateByChanneltrue and false branches both covered - 6.5 OTel instruments emitted from production paths, asserted with real in-memory
MeterProvider - 6.6 In-memory store dedup tested (duplicate membership add throws)
- 6.7 No retroactive tick — every box reflects work done in this change
7. Archive
- 7.1 Fold spec delta into
openspec/specs/contacts/spec.md - 7.2 Move
openspec/changes/migrate-contacts→openspec/archive/2026-05-20-migrate-contacts - 7.3 Refresh
MANIFEST.md